Use separate DB connection pools for read/update in platform update benchmark #1816
+39
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
reviewed
Mar 16, 2023
vonzshik
reviewed
Mar 17, 2023
|
There's been lots of changes recently, let's hold off on merging this for a bit, to have some stability in the dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up #1764 again, which is @NinoFloris's idea to separate read and write operations to separate pools to prevent head-of-line perf issues.
Unfortunately the volatility of the updates benchmark makes it impossible to say with clarity how this does; but it does seem to improve perf in a consistent way. I suggest merging this and tracking what it does to updates for a few days, we can decide whether to keep it or not after that.
/cc @sebastienros @ajcvickers